Re: [Qemu-devel] [PATCH] target/arm: Fix SMMLS argument order

2019-09-03 Thread Peter Maydell
On Thu, 29 Aug 2019 at 02:34, Richard Henderson wrote: > > The previous simplification got the order of operands to the > subtraction wrong. Since the 64-bit product is the subtrahend, > we must use a 64-bit subtract to properly compute the borrow > from the low-part of the product. > > Fixes: 5f

Re: [Qemu-devel] [PATCH] target/arm: Fix SMMLS argument order

2019-08-29 Thread Laurent Desnogues
Hi, On Thu, Aug 29, 2019 at 3:33 AM Richard Henderson wrote: > > The previous simplification got the order of operands to the > subtraction wrong. Since the 64-bit product is the subtrahend, > we must use a 64-bit subtract to properly compute the borrow > from the low-part of the product. > > Fi

[Qemu-devel] [PATCH] target/arm: Fix SMMLS argument order

2019-08-28 Thread Richard Henderson
The previous simplification got the order of operands to the subtraction wrong. Since the 64-bit product is the subtrahend, we must use a 64-bit subtract to properly compute the borrow from the low-part of the product. Fixes: 5f8cd06ebcf5 ("target/arm: Simplify SMMLA, SMMLAR, SMMLS, SMMLSR") Repo