Re: [Qemu-devel] [PATCH] target/ppc: fix compilation breakage on windows

2018-12-17 Thread Peter Maydell
On Mon, 17 Dec 2018 at 05:01, David Gibson wrote: > > On Sat, Dec 15, 2018 at 07:42:22PM +0100, Cédric Le Goater wrote: > > -#define PPC_BIT(bit)(0x8000UL >> (bit)) > > -#define PPC_BIT32(bit) (0x8000UL >> (bit)) > > -#define PPC_BIT8(bit) (0x80UL >>

Re: [Qemu-devel] [PATCH] target/ppc: fix compilation breakage on windows

2018-12-16 Thread Cédric Le Goater
On 12/17/18 5:50 AM, David Gibson wrote: > On Sat, Dec 15, 2018 at 07:42:22PM +0100, Cédric Le Goater wrote: >> Fix the PPC_BIT definitions to use ULL instead in UL and replace >> __builtin_ffssl() by the equivalent ctz routines. >> >> Signed-off-by: Cédric Le Goater >> --- >> >> Compile tested w

Re: [Qemu-devel] [PATCH] target/ppc: fix compilation breakage on windows

2018-12-16 Thread David Gibson
On Sat, Dec 15, 2018 at 07:42:22PM +0100, Cédric Le Goater wrote: > Fix the PPC_BIT definitions to use ULL instead in UL and replace > __builtin_ffssl() by the equivalent ctz routines. > > Signed-off-by: Cédric Le Goater > --- > > Compile tested with --cross-prefix=x86_64-w64-mingw32-. When I h

[Qemu-devel] [PATCH] target/ppc: fix compilation breakage on windows

2018-12-15 Thread Cédric Le Goater
Fix the PPC_BIT definitions to use ULL instead in UL and replace __builtin_ffssl() by the equivalent ctz routines. Signed-off-by: Cédric Le Goater --- Compile tested with --cross-prefix=x86_64-w64-mingw32-. When I have some more time, I might try runtime on windows also. The PPC compile fail