Re: [Qemu-devel] [PATCH] target/sh4: optimize cross-page and indirect jumps

2017-06-08 Thread Richard Henderson
On 06/07/2017 02:20 PM, Aurelien Jarno wrote: if (ctx->singlestep_enabled) gen_helper_debug(cpu_env); -tcg_gen_exit_tb(0); +tcg_gen_lookup_and_goto_ptr(cpu_pc); That really should be an else for that if, since helper_debug doesn't return. r~

[Qemu-devel] [PATCH] target/sh4: optimize cross-page and indirect jumps

2017-06-07 Thread Aurelien Jarno
Instead of unconditionally exiting to the exec loop for indirect jumps or cross-page direct jumps, use the lookup_and_goto_ptr helper to jump to the target if it is valid. Signed-off-by: Aurelien Jarno --- target/sh4/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2