Re: [Qemu-devel] [PATCH] target-arm: Correct handling of writes to CPSR mode bits from gdb in usermode

2016-02-29 Thread Sergey Fedorov
On 29.02.2016 19:47, Peter Maydell wrote: In helper.c the expression (env->uncached_cpsr & CPSR_M) != CPSR_USER is always true; the right hand side was supposed to be ARM_CPU_MODE_USR (an error in commit cb01d391). Since the incorrect expression was always true, this just meant that commit cb

[Qemu-devel] [PATCH] target-arm: Correct handling of writes to CPSR mode bits from gdb in usermode

2016-02-29 Thread Peter Maydell
In helper.c the expression (env->uncached_cpsr & CPSR_M) != CPSR_USER is always true; the right hand side was supposed to be ARM_CPU_MODE_USR (an error in commit cb01d391). Since the incorrect expression was always true, this just meant that commit cb01d391 had no effect. However simply changin