Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-11-14 Thread Peter Maydell
On 4 November 2010 22:21, Adam Lackorzynski wrote: > > Refine check on bkpt so that smc and undefined instruction encodings are > handled as an undefined instruction and trap. > > Signed-off-by: Adam Lackorzynski This patch looks good to me. I note that there's actually an implementation of SMC

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-11-04 Thread Adam Lackorzynski
Refine check on bkpt so that smc and undefined instruction encodings are handled as an undefined instruction and trap. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-25 Thread Adam Lackorzynski
Refine check on bkpt so that smc and undefined instruction encodings are handled as an undefined instruction and trap. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Adam Lackorzynski
On Thu Sep 02, 2010 at 23:14:23 +0100, Peter Maydell wrote: > On Thu, Sep 02, 2010 at 11:40:50PM +0200, Adam Lackorzynski wrote: > > +case 7: > > +/* SMC? */ > > +if ((insn & 0xfff0) == 0xe1600070) { > > +goto illegal_op; > > +} > > +

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Peter Maydell
On Thu, Sep 02, 2010 at 11:40:50PM +0200, Adam Lackorzynski wrote: > +case 7: > +/* SMC? */ > +if ((insn & 0xfff0) == 0xe1600070) { > +goto illegal_op; > +} > +/* bkpt */ This doesn't look right to me. SMC in the ARM encod

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Adam Lackorzynski
Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 6fcd

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Stefan Weil
Am 02.09.2010 22:27, schrieb Adam Lackorzynski: Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-a

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Adam Lackorzynski
Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 6fcd

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-06-04 Thread Adam Lackorzynski
Handle smc as undefined instruction instead of having it wrongly interpreted as some other instruction. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-05-10 Thread Adam Lackorzynski
Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 0eccca5..afd6716 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -6344,7 +6344,11 @