Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription

2015-05-26 Thread Peter Maydell
On 26 May 2015 at 00:58, Edgar E. Iglesias wrote: > That's all OK I think. We've never used the save/restore/migration on > CRIS so you won't be breaking anything for us... I would actually recommend fixing it in the board/device models just for debugging purposes. It's really handy to be able to

Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription

2015-05-25 Thread Edgar E. Iglesias
On Mon, May 25, 2015 at 04:53:19PM +0100, Peter Maydell wrote: > From: Juan Quintela > > Update the CRIS CPU state save/load to use a VMStateDescription struct > rather than cpu_save/cpu_load functions. > > Have to define TLBSet struct. > Multidimensional arrays in C are a mess, just unroll them

Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription

2015-05-25 Thread Peter Maydell
On 25 May 2015 at 19:46, Peter Crosthwaite wrote: > On Mon, May 25, 2015 at 11:30 AM, Peter Maydell > wrote: >> In looking at this I found that we currently have: >> CPUs that set cc->vmsd: arm, i386, lm32, mips, moxie, ppc, s390x >> CPUs that set dc->vmsd: alpha, m68k, microblaze, openrisc, sh4,

Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription

2015-05-25 Thread Peter Crosthwaite
On Mon, May 25, 2015 at 11:30 AM, Peter Maydell wrote: > On 25 May 2015 at 17:35, Peter Maydell wrote: >> On 25 May 2015 at 16:53, Peter Maydell wrote: >>> From: Juan Quintela >>> >>> Update the CRIS CPU state save/load to use a VMStateDescription struct >>> rather than cpu_save/cpu_load functi

Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription

2015-05-25 Thread Peter Maydell
On 25 May 2015 at 17:35, Peter Maydell wrote: > On 25 May 2015 at 16:53, Peter Maydell wrote: >> From: Juan Quintela >> >> Update the CRIS CPU state save/load to use a VMStateDescription struct >> rather than cpu_save/cpu_load functions. > Oops, this has a couple of issues I only noticed when I

Re: [Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription

2015-05-25 Thread Peter Maydell
On 25 May 2015 at 16:53, Peter Maydell wrote: > From: Juan Quintela > > Update the CRIS CPU state save/load to use a VMStateDescription struct > rather than cpu_save/cpu_load functions. > > Have to define TLBSet struct. > Multidimensional arrays in C are a mess, just unroll them. > > Signed-off-b

[Qemu-devel] [PATCH] target-cris: update CPU state save/load to use VMStateDescription

2015-05-25 Thread Peter Maydell
From: Juan Quintela Update the CRIS CPU state save/load to use a VMStateDescription struct rather than cpu_save/cpu_load functions. Have to define TLBSet struct. Multidimensional arrays in C are a mess, just unroll them. Signed-off-by: Juan Quintela [PMM: * expand commit message a little sinc