Re: [Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-12 Thread Eduardo Habkost
On Wed, Feb 10, 2016 at 12:02:47PM +0100, Asia Slowinska wrote: > Stick to the expected order of the FPU registers in xsave (as specified in > the > Intel manual.) Otherwise, instructions loading the FPU state don't set it > up > correctly. > > To set up FPU, software needs to provide a buffer of

Re: [Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 12:02, Asia Slowinska wrote: > Stick to the expected order of the FPU registers in xsave (as specified > in the > Intel manual.) Otherwise, instructions loading the FPU state don't set > it up > correctly. > > To set up FPU, software needs to provide a buffer of 80 bytes > storing

Re: [Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-10 Thread Asia Slowinska
Many thanks for the reply. I'm sorry for the typo in the previous patch. Below comes a new one. Best regards, asia Stick to the right order of the FPU registers in xsave (as specified in the Intel manual.) Otherwise, instructions loading the FPU state don't set it up correctly. To set up FPU,

[Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-10 Thread Asia Slowinska
Stick to the expected order of the FPU registers in xsave (as specified in the Intel manual.) Otherwise, instructions loading the FPU state don't set it up correctly. To set up FPU, software needs to provide a buffer of 80 bytes storing 8 FPU registers. They are organized in a stack. FPU assumes