Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction v2

2011-12-14 Thread Peter Maydell
Jason, ping? Are you going to do a v3 of this patch? Thanks -- PMM On 19 November 2011 16:20, Peter Maydell peter.mayd...@linaro.org wrote: On 8 November 2011 14:20, Jason Wessel jason.wes...@windriver.com wrote: The maxsd instruction needs to take into account the sign of the numbers 64 bit

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction v2

2011-11-19 Thread Peter Maydell
On 8 November 2011 14:20, Jason Wessel jason.wes...@windriver.com wrote: The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers.  This is a regression that was introduced in 347ac8e356 (target-i386: switch to softfloat). The case that fails is: maxsd  

[Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Jason Wessel
The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers. This is a regression that was introduced in 347ac8e356 (target-i386: switch to softfloat). The case that fails is: maxsd %xmm1,%xmm0 When xmm1 = 24 and xmm0 = -100 This was found running the glib2

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Laurent Desnogues
On Tue, Nov 8, 2011 at 2:00 PM, Jason Wessel jason.wes...@windriver.com wrote: The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers.  This is a regression that was introduced in 347ac8e356 (target-i386: switch to softfloat). The case that fails is: maxsd  

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Jason Wessel
On 11/08/2011 07:48 AM, Laurent Desnogues wrote: On Tue, Nov 8, 2011 at 2:00 PM, Jason Wessel jason.wes...@windriver.com wrote: The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers. This is a regression that was introduced in 347ac8e356 (target-i386:

[Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction v2

2011-11-08 Thread Jason Wessel
The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers. This is a regression that was introduced in 347ac8e356 (target-i386: switch to softfloat). The case that fails is: maxsd %xmm1,%xmm0 When xmm1 = 24 and xmm0 = -100 This was found running the glib2

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Peter Maydell
On 8 November 2011 14:22, Jason Wessel jason.wes...@windriver.com wrote: +#define FPU_MIN(size, a, b) float ## size ## _lt(a, b, env-sse_status) ? (a) : (b) +#define FPU_MAX(size, a, b) float ## size ## _lt(b, a, env-sse_status) ? (a) : (b) This will give the wrong answers for special cases

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Jason Wessel
On 11/08/2011 08:40 AM, Peter Maydell wrote: On 8 November 2011 14:22, Jason Wessel jason.wes...@windriver.com wrote: +#define FPU_MIN(size, a, b) float ## size ## _lt(a, b, env-sse_status) ? (a) : (b) +#define FPU_MAX(size, a, b) float ## size ## _lt(b, a, env-sse_status) ? (a) : (b) This

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Peter Maydell
On 8 November 2011 14:45, Jason Wessel jason.wes...@windriver.com wrote: On 11/08/2011 08:40 AM, Peter Maydell wrote: On 8 November 2011 14:22, Jason Wessel jason.wes...@windriver.com wrote: +#define FPU_MIN(size, a, b) float ## size ## _lt(a, b, env-sse_status) ? (a) : (b) +#define