Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-09-12 Thread Peter Maydell
Ping^4! thanks -- PMM On 2 September 2013 09:24, Peter Maydell wrote: > Ping^3! > > thanks > -- PMM > > On 20 August 2013 13:59, Peter Maydell wrote: >> Ping^2! This has been reviewed and I've checked that the >> patch still applies to master. >> >> thanks >> -- PMM >> >> On 25 July 2013 17:54,

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-09-02 Thread Peter Maydell
Ping^3! thanks -- PMM On 20 August 2013 13:59, Peter Maydell wrote: > Ping^2! This has been reviewed and I've checked that the > patch still applies to master. > > thanks > -- PMM > > On 25 July 2013 17:54, Peter Maydell wrote: >> Ping! >> >> (patchwork url: http://patchwork.ozlabs.org/patch/25

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-08-20 Thread Richard Henderson
On 08/20/2013 05:59 AM, Peter Maydell wrote: > Ping^2! This has been reviewed and I've checked that the > patch still applies to master. Reviewed-by: Richard Henderson > > thanks > -- PMM > > On 25 July 2013 17:54, Peter Maydell wrote: >> Ping! >> >> (patchwork url: http://patchwork.ozlabs.or

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-08-20 Thread Peter Maydell
Ping^2! This has been reviewed and I've checked that the patch still applies to master. thanks -- PMM On 25 July 2013 17:54, Peter Maydell wrote: > Ping! > > (patchwork url: http://patchwork.ozlabs.org/patch/259148/) > > thanks > -- PMM > > On 15 July 2013 18:21, Peter Maydell wrote: >> The ins

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-07-25 Thread Richard Henderson
On 07/25/2013 06:54 AM, Peter Maydell wrote: > Ping! > > (patchwork url: http://patchwork.ozlabs.org/patch/259148/) Reviewed-by: Richard Henderson r~ > > thanks > -- PMM > > On 15 July 2013 18:21, Peter Maydell wrote: >> The instructions CMOVcc, FCMOVcc and F[U]COMI[P] should only be >> pr

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-07-25 Thread Peter Maydell
Ping! (patchwork url: http://patchwork.ozlabs.org/patch/259148/) thanks -- PMM On 15 July 2013 18:21, Peter Maydell wrote: > The instructions CMOVcc, FCMOVcc and F[U]COMI[P] should only be > present if the CMOV feature bit is set. Add missing feature bit > checks so we correctly fault if emulat

[Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-07-15 Thread Peter Maydell
The instructions CMOVcc, FCMOVcc and F[U]COMI[P] should only be present if the CMOV feature bit is set. Add missing feature bit checks so we correctly fault if emulating a 486 or 586. This fixes bug LP:1201446. Signed-off-by: Peter Maydell --- target-i386/translate.c | 19 +++