Re: [Qemu-devel] [PATCH] target-i386: Use struct X86XSaveArea in fpu_helper.c

2016-07-03 Thread Eduardo Habkost
On Sat, Jul 02, 2016 at 04:45:11PM -0700, Richard Henderson wrote: > On 07/02/2016 01:02 PM, Eduardo Habkost wrote: > > On Sat, Jul 02, 2016 at 09:44:31AM -0700, Richard Henderson wrote: > > [...] > > > @@ -1402,9 +1409,8 @@ void helper_xrstor(CPUX86State *env, target_ulong > > > ptr, uint64_t

Re: [Qemu-devel] [PATCH] target-i386: Use struct X86XSaveArea in fpu_helper.c

2016-07-02 Thread Richard Henderson
On 07/02/2016 01:02 PM, Eduardo Habkost wrote: On Sat, Jul 02, 2016 at 09:44:31AM -0700, Richard Henderson wrote: [...] @@ -1402,9 +1409,8 @@ void helper_xrstor(CPUX86State *env, target_ulong ptr, uint64_t rfbm) } /* The XCOMP field must be zero. */ -xcomp_bv0 =

Re: [Qemu-devel] [PATCH] target-i386: Use struct X86XSaveArea in fpu_helper.c

2016-07-02 Thread Eduardo Habkost
On Sat, Jul 02, 2016 at 09:44:31AM -0700, Richard Henderson wrote: [...] > @@ -1402,9 +1409,8 @@ void helper_xrstor(CPUX86State *env, target_ulong ptr, > uint64_t rfbm) > } > > /* The XCOMP field must be zero. */ > -xcomp_bv0 = cpu_ldq_data_ra(env, ptr + 520, ra); > -

[Qemu-devel] [PATCH] target-i386: Use struct X86XSaveArea in fpu_helper.c

2016-07-02 Thread Richard Henderson
This avoids a double hand-full of magic numbers in the xsave and xrstor helper functions. Signed-off-by: Richard Henderson --- target-i386/cpu.c| 7 +++- target-i386/cpu.h| 7 target-i386/fpu_helper.c | 99 +---