Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks

2014-12-03 Thread Maciej W. Rozycki
On Wed, 3 Dec 2014, Leon Alrae wrote: > > -env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0; > > +if (env->insn_flags & ISA_MIPS3) > > +env->hflags |= MIPS_HFLAG_64; > > According to the CODING_STYLE braces are required even for a single > statement "if" b

Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks

2014-12-03 Thread Leon Alrae
On 19/11/2014 14:20, Maciej W. Rozycki wrote: > -env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0; > +if (env->insn_flags & ISA_MIPS3) > +env->hflags |= MIPS_HFLAG_64; According to the CODING_STYLE braces are required even for a single statement "if" block.

[Qemu-devel] [PATCH] target-mips: Tighten ISA level checks

2014-11-19 Thread Maciej W. Rozycki
Tighten ISA level checks down to MIPS II that many of our instructions are missing. Also make sure any 64-bit instruction enables are only applied to 64-bit processors, that is ones that implement at least the MIPS III ISA. Signed-off-by: Maciej W. Rozycki --- Hi, As usually with changes that