From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson
[r...@twiddle.net]
Sent: Friday, June 28, 2013 7:40 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target
On 06/27/2013 02:48 PM, Petar Jovanovic wrote:
>> This doesn't look right either, as it doesn't properly check for overflow of
>> negative values.
>
> What overflow of negative values?
> Can you please list the values for which the result would not be correct?
Hmm, I suppose since we're always ro
] target-mips: fix mipsdsp_trunc16_sat16_round
On 06/17/2013 03:39 PM, Petar Jovanovic wrote:
> -int64_t temp;
> -
> -temp = (int32_t)a + 0x8000;
> +uint16_t temp;
>
> -if (a > (int)0x7fff8000) {
> -temp = 0x7FFF;
> +if (a > 0x7FFF7F
On 06/17/2013 03:39 PM, Petar Jovanovic wrote:
> -int64_t temp;
> -
> -temp = (int32_t)a + 0x8000;
> +uint16_t temp;
>
> -if (a > (int)0x7fff8000) {
> -temp = 0x7FFF;
> +if (a > 0x7FFF7FFF) {
> +temp = 0x7FFF;
> set_DSPControl_overflow_flag(1, 2
ping
From: Petar Jovanovic
Sent: Tuesday, June 18, 2013 12:39 AM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: aurel...@aurel32.net
Subject: RE: [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round
ping
From: Petar
ping
From: Petar Jovanovic
Sent: Sunday, June 09, 2013 4:34 AM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: aurel...@aurel32.net
Subject: RE: [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round
ping
http://patchwork.ozlabs.org/patch/245624/
ping
http://patchwork.ozlabs.org/patch/245624/
From: Petar Jovanovic [petar.jovano...@rt-rk.com]
Sent: Wednesday, May 22, 2013 3:35 PM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurel...@aurel32.net
Subject: [PATCH] target-mips: fix mipsdsp_trunc16_sat1
From: Petar Jovanovic
This change corrects rounding and saturation of Q31 fractional value in
mipsdsp_trunc16_sat16_round(). Overflow detection was incorrect for the
corner case for PRECRQ_RS.PH, and this test case is also part of the change.
Signed-off-by: Petar Jovanovic
---
target-mips/dsp_
