Re: [Qemu-devel] [PATCH] target-ppc: remove useless line

2010-05-31 Thread Aurelien Jarno
On Fri, May 28, 2010 at 09:00:45PM +0200, Thomas Monjalon wrote: > From: Thomas Monjalon > > This line was a bit clear. > The next lines set or reset this bit (LE) depending of another bit (ILE). > So the first line is useless. Thanks, applied. > Signed-off-by: Thomas Monjalon > --- > target-

Re: [Qemu-devel] [PATCH] target-ppc: remove useless line

2010-05-31 Thread Alexander Graf
Thomas Monjalon wrote: > Alexander Graf wrote: > >> Thomas, have you verified that it still boots a ppc64 guest? >> > > No, but I don't see any specific link between ppc64 and this change. > > This is the current (pseudo)code: > LE = 0 > if ILE == 1 > LE = 1 > else >

Re: [Qemu-devel] [PATCH] target-ppc: remove useless line

2010-05-31 Thread Thomas Monjalon
Alexander Graf wrote: > Thomas, have you verified that it still boots a ppc64 guest? No, but I don't see any specific link between ppc64 and this change. This is the current (pseudo)code: LE = 0 if ILE == 1 LE = 1 else LE = 0 In all cases, LE will be overwritten after

Re: [Qemu-devel] [PATCH] target-ppc: remove useless line

2010-05-31 Thread Alexander Graf
On 29.05.2010, at 15:31, Andreas Färber wrote: > Am 28.05.2010 um 21:00 schrieb Thomas Monjalon: > >> From: Thomas Monjalon >> >> This line was a bit clear. >> The next lines set or reset this bit (LE) depending of another bit (ILE). >> So the first line is useless. >> >> Signed-off-by: Thoma

Re: [Qemu-devel] [PATCH] target-ppc: remove useless line

2010-05-29 Thread Andreas Färber
Am 28.05.2010 um 21:00 schrieb Thomas Monjalon: From: Thomas Monjalon This line was a bit clear. The next lines set or reset this bit (LE) depending of another bit (ILE). So the first line is useless. Signed-off-by: Thomas Monjalon --- target-ppc/helper.c |1 - 1 files changed, 0 inser

[Qemu-devel] [PATCH] target-ppc: remove useless line

2010-05-28 Thread Thomas Monjalon
From: Thomas Monjalon This line was a bit clear. The next lines set or reset this bit (LE) depending of another bit (ILE). So the first line is useless. Signed-off-by: Thomas Monjalon --- target-ppc/helper.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-ppc/he