Dne 25.2.2017 v 21:39 Michal Marek napsal(a):
> Dne 25.2.2017 v 01:05 Richard Henderson napsal(a):
>> On 02/25/2017 12:44 AM, Michal Marek wrote:
>>> +static int do_stfle(CPUS390XState *env, uint64_t addr, int len)
>>> +{
>>> +S390CPU *cpu = s390_env_get_cpu(env);
>>> +uint8_t data[64];
>>
Dne 25.2.2017 v 01:05 Richard Henderson napsal(a):
> On 02/25/2017 12:44 AM, Michal Marek wrote:
>> +DEF_HELPER_1(stfl, void, env)
>
> DEF_HELPER_FLAGS_1(stfl, TCG_CALL_NO_RWG, void, env)
>
> since this touches no registers, and only writes to lomem which afaik
> cannot fault in kernel mode.
OK.
On 02/25/2017 12:44 AM, Michal Marek wrote:
+DEF_HELPER_1(stfl, void, env)
DEF_HELPER_FLAGS_1(stfl, TCG_CALL_NO_RWG, void, env)
since this touches no registers, and only writes to lomem which afaik cannot
fault in kernel mode.
+DEF_HELPER_3(stfle, i64, env, i64, i64)
Unfortunately, we ar
Am 24.02.2017 um 16:22 schrieb Michal Marek:
> On 2017-02-24 15:51, no-re...@patchew.org wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
> [...]
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/1: target-s390x: Implement stfl and stfle.
On 2017-02-24 15:51, no-re...@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
[...]
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: target-s390x: Implement stfl and stfle...
> ERROR: braces {} are necessary for all arms of th
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170224134411.28882-1-mma...@suse.com
Type: series
Subject: [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git
The implementation is partially cargo cult based, but it works for the
linux kernel use case.
Signed-off-by: Michal Marek
---
target/s390x/cpu_features.c | 6 --
target/s390x/cpu_features.h | 2 +-
target/s390x/helper.h | 2 ++
target/s390x/insn-data.def | 2 ++
target/s390x/misc_
