Re: [Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-20 Thread Blue Swirl
On 2/19/10, Jay Foad jay.f...@gmail.com wrote: On Linux/x86, configuring with --enable-debug, I get: CCsparc64-linux-user/translate.o /home/foad/git/qemu/target-sparc/translate.c: In function ‘gen_load_trap_state_at_tl’: /home/foad/git/qemu/target-sparc/translate.c:1684: error:

Re: [Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-20 Thread Jay Foad
Yes, except for the Signed-off-by: line. Do I need to resend it for that? And if so, does that make it PATCH v2 (even though the patch hasn't changed)? Or can I just put the fixed Signed-off-by: line in a reply? Thanks, Jay.

Re: [Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-20 Thread Blue Swirl
On 2/20/10, Jay Foad jay.f...@gmail.com wrote: Yes, except for the Signed-off-by: line. Do I need to resend it for that? And if so, does that make it PATCH v2 (even though the patch hasn't changed)? Or can I just put the fixed Signed-off-by: line in a reply? I'd suppose you'd also want

[Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-19 Thread Jay Foad
On Linux/x86, configuring with --enable-debug, I get:  CC    sparc64-linux-user/translate.o /home/foad/git/qemu/target-sparc/translate.c: In function ‘gen_load_trap_state_at_tl’: /home/foad/git/qemu/target-sparc/translate.c:1684: error: incompatible type for argument 3 of ‘tcg_gen_add_i32’