Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-09-02 Thread Andreas Färber
Am 02.09.2015 um 11:02 schrieb Paolo Bonzini: > On 01/09/2015 18:31, Andreas Färber wrote: >> Breaking stderr log attached. Diff below. >> >> ffc6372851d8631a9f9fa56ec613b3244dc635b9^ vs. >> ffc6372851d8631a9f9fa56ec613b3244dc635b9: > > Richard already answered (and sent a patch), but I also have

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-09-02 Thread Richard Henderson
On 09/02/2015 02:02 AM, Paolo Bonzini wrote: On 01/09/2015 18:31, Andreas Färber wrote: Breaking stderr log attached. Diff below. ffc6372851d8631a9f9fa56ec613b3244dc635b9^ vs. ffc6372851d8631a9f9fa56ec613b3244dc635b9: Richard already answered (and sent a patch), but I also have a question:

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-09-02 Thread Paolo Bonzini
On 01/09/2015 18:31, Andreas Färber wrote: > Breaking stderr log attached. Diff below. > > ffc6372851d8631a9f9fa56ec613b3244dc635b9^ vs. > ffc6372851d8631a9f9fa56ec613b3244dc635b9: Richard already answered (and sent a patch), but I also have a question: are you using --disable-guest-base, and i

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-09-01 Thread Richard Henderson
On 09/01/2015 09:31 AM, Andreas Färber wrote: -0x006cd98c: f83f6a95 str x21, [x20, xzr] +0x006cd98c: f8346bf5 str x21, [sp, x20] Thanks. Sorry it took me so long to get back to this. I've sent a patch to the list. I intended to cc you, but somehow forgot at the last second. r~

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-09-01 Thread Andreas Färber
Am 29.08.2015 um 08:50 schrieb Paolo Bonzini: > On 28/08/2015 01:47, Andreas Färber wrote: >> The argument order for the !CONFIG_SOFTMMU case was jumbled up since >> ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit >> offset for 32-bit user-mode emulation"), regressing from -rc2 t

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-28 Thread Paolo Bonzini
On 28/08/2015 01:47, Andreas Färber wrote: > The argument order for the !CONFIG_SOFTMMU case was jumbled up since > ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit > offset for 32-bit user-mode emulation"), regressing from -rc2 to v2.4.0. > Fix their order to avoid segfaults, e

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-28 Thread Richard Henderson
On 08/28/2015 09:23 AM, Andreas Färber wrote: An otype argument is being inserted as next-to-last argument for the function definitions. Same for the softmmu callsites. Only in the *-user callsites the argument order is being changed with addr_reg and off_r switching order? I don't see why that s

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-28 Thread Andreas Färber
Am 27.08.2015 um 22:30 schrieb Richard Henderson: > On 08/27/2015 04:47 PM, Andreas Färber wrote: >> The argument order for the !CONFIG_SOFTMMU case was jumbled up since >> ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit >> offset for 32-bit user-mode emulation"), regressing from

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-27 Thread Richard Henderson
On 08/27/2015 04:47 PM, Andreas Färber wrote: The argument order for the !CONFIG_SOFTMMU case was jumbled up since ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit offset for 32-bit user-mode emulation"), regressing from -rc2 to v2.4.0. Fix their order to avoid segfaults, e.g.,

[Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-27 Thread Andreas Färber
The argument order for the !CONFIG_SOFTMMU case was jumbled up since ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit offset for 32-bit user-mode emulation"), regressing from -rc2 to v2.4.0. Fix their order to avoid segfaults, e.g., in openSUSE's GNU coreutils 8.24. Cc: Paolo Bon