Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-25 Thread Eduardo Habkost
On Fri, Apr 21, 2017 at 11:38:30AM +0200, Paolo Bonzini wrote: > > > On 20/04/2017 20:42, Eduardo Habkost wrote: > >> -smp 4,threads=4 shows 4 cores > > This means 1 socket with 1 core, 4 threads per core. But if > > vendor ID is AMD, guests will probably ignore the hyperthreading > > info and tr

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-21 Thread Paolo Bonzini
On 20/04/2017 20:42, Eduardo Habkost wrote: >> -smp 4,threads=4 shows 4 cores > This means 1 socket with 1 core, 4 threads per core. But if > vendor ID is AMD, guests will probably ignore the hyperthreading > info and treat each thread as a separate core. That's why we have > a warning. I'm not

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-20 Thread Eduardo Habkost
On Thu, Apr 20, 2017 at 12:14:18AM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 10:26 PM, Eduardo Habkost wrote: > > On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote: > >> On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost > >> wrote: > >> > On Wed, Apr 19, 2017 at 05:25:23PM

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Pranith Kumar
On Wed, Apr 19, 2017 at 10:26 PM, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote: >> On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote: >> > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: >> >> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo H

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Eduardo Habkost
On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote: > > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: > >> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost > >> wrote: > >> > On Wed, Apr 19, 2017 at 04:16:53PM

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Pranith Kumar
On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: >> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote: >> > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote: >> >> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Ha

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Eduardo Habkost
On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote: > > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote: > >> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost > >> wrote: > >> > On Wed, Apr 19, 2017 at 04:00:49PM

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Pranith Kumar
On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote: >> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost wrote: >> > On Wed, Apr 19, 2017 at 04:00:49PM -0400, Pranith Kumar wrote: >> >> On Wed, Apr 19, 2017 at 3:54 PM, Pranith Ku

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Eduardo Habkost
On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost wrote: > > On Wed, Apr 19, 2017 at 04:00:49PM -0400, Pranith Kumar wrote: > >> On Wed, Apr 19, 2017 at 3:54 PM, Pranith Kumar > >> wrote: > >> > When we enable hyperthreading (using

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Pranith Kumar
On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost wrote: > On Wed, Apr 19, 2017 at 04:00:49PM -0400, Pranith Kumar wrote: >> On Wed, Apr 19, 2017 at 3:54 PM, Pranith Kumar wrote: >> > When we enable hyperthreading (using threads smp argument), we warn >> > the user if the cpu is an AMD cpu. This d

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Eduardo Habkost
On Wed, Apr 19, 2017 at 04:00:49PM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 3:54 PM, Pranith Kumar wrote: > > When we enable hyperthreading (using threads smp argument), we warn > > the user if the cpu is an AMD cpu. This does not make sense on TCG and > > is also obsolete now that AM

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Pranith Kumar
On Wed, Apr 19, 2017 at 3:54 PM, Pranith Kumar wrote: > When we enable hyperthreading (using threads smp argument), we warn > the user if the cpu is an AMD cpu. This does not make sense on TCG and > is also obsolete now that AMD Ryzen support hyperthreading. > > Fix this by adding CPUID_HT bit to

[Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-19 Thread Pranith Kumar
When we enable hyperthreading (using threads smp argument), we warn the user if the cpu is an AMD cpu. This does not make sense on TCG and is also obsolete now that AMD Ryzen support hyperthreading. Fix this by adding CPUID_HT bit to the TCG features and explicitly checking this bit in the cpuid.