Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-26 Thread Peter Maydell
On 25 April 2017 at 11:43, Richard Henderson wrote: > Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize > the output. Even though this code is dead, it gets translated, and > without the initialization we encounter a tcg_error. > > Reported-by: Nikunj A

Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-26 Thread Richard Henderson
On 04/26/2017 12:40 PM, Nikunj A Dadhania wrote: -> cc->cpu_exec_enter() = ppc_cpu_exec_enter() Sets env->reserve_addr = -1; This is the bug. We should be doing this in powerpc_excp instead. I'm quite frankly surprised that we don't see

Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-26 Thread Nikunj A Dadhania
Richard Henderson writes: > Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize > the output. Even though this code is dead, it gets translated, and > without the initialization we encounter a tcg_error. > > Reported-by: Nikunj A Dadhania

Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-26 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > aNikunj A Dadhania writes: > >> Richard Henderson writes: >> >>> On 04/25/2017 01:21 PM, Nikunj A Dadhania wrote: Richard Henderson writes: > Users of

Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-26 Thread Nikunj A Dadhania
aNikunj A Dadhania writes: > Richard Henderson writes: > >> On 04/25/2017 01:21 PM, Nikunj A Dadhania wrote: >>> Richard Henderson writes: >>> Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize the

Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-26 Thread aNikunj A Dadhania
Richard Henderson writes: > On 04/25/2017 01:21 PM, Nikunj A Dadhania wrote: >> Richard Henderson writes: >> >>> Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize >>> the output. Even though this code is dead, it gets translated, and >>>

Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-25 Thread Richard Henderson
On 04/25/2017 01:21 PM, Nikunj A Dadhania wrote: Richard Henderson writes: Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize the output. Even though this code is dead, it gets translated, and without the initialization we encounter a tcg_error.

Re: [Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-25 Thread Nikunj A Dadhania
Richard Henderson writes: > Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize > the output. Even though this code is dead, it gets translated, and > without the initialization we encounter a tcg_error. > > Reported-by: Nikunj A Dadhania

[Qemu-devel] [PATCH] tcg: Initialize return value after exit_atomic

2017-04-25 Thread Richard Henderson
Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize the output. Even though this code is dead, it gets translated, and without the initialization we encounter a tcg_error. Reported-by: Nikunj A Dadhania Signed-off-by: Richard Henderson