Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes build for s390 hosts)

2011-10-08 Thread Blue Swirl
On Fri, Oct 7, 2011 at 6:26 PM, Stefan Weil wrote: > Am 07.10.2011 20:13, schrieb Richard Henderson: >> >> On 10/07/2011 11:00 AM, Stefan Weil wrote: >>> >>> +#define TCGReg int /* TODO: Remove this line when tcg-target.c uses >>> TCGReg. */ >> >> Nack. This is too ugly to live. Fully agree. >>

Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes build for s390 hosts)

2011-10-07 Thread Stefan Weil
Am 07.10.2011 20:13, schrieb Richard Henderson: On 10/07/2011 11:00 AM, Stefan Weil wrote: +#define TCGReg int /* TODO: Remove this line when tcg-target.c uses TCGReg. */ Nack. This is too ugly to live. How hard can it be to simply change the prototype in each of the backend files instead? Ye

Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes build for s390 hosts)

2011-10-07 Thread Richard Henderson
On 10/07/2011 11:00 AM, Stefan Weil wrote: > +#define TCGReg int /* TODO: Remove this line when tcg-target.c uses TCGReg. > */ Nack. This is too ugly to live. How hard can it be to simply change the prototype in each of the backend files instead? Yes, full conversion to TCGReg is desirable, bu

[Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes build for s390 hosts)

2011-10-07 Thread Stefan Weil
s390 already uses TCGReg - this patch defines TCGReg for all other TCG targets. The targets still don't use TCGReg, therefore a temporary define maps 'TCGReg' to 'int' for all unfinished targets. This define allows usage of TCGReg in tcg.c thus fixing some forward declarations which had broken co