Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-03-03 Thread Stuart Brady
On Mon, Feb 22, 2010 at 05:35:16PM +0100, Stefan Weil wrote: > Maybe my comment applies also to the change in > tcg/hppa/tcg-target.c, but I tested only ppc > (using cross compilation). HPPA host support is 32-bit only for the time being, as there isn't even a 64-bit userspace for HPPA, yet, and t

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Stefan Weil
Jay Foad schrieb: >>> --- a/tcg/ppc/tcg-target.c >>> +++ b/tcg/ppc/tcg-target.c >>> @@ -1693,7 +1693,6 @@ static const TCGTargetOpDef ppc_op_defs[] = { >>> { INDEX_op_qemu_ld16u, { "r", "L" } }, >>> { INDEX_op_qemu_ld16s, { "r", "L" } }, >>> { INDEX_op_qemu_ld32u, { "r", "L" } }, >>>

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread malc
On Mon, 22 Feb 2010, Jay Foad wrote: > The qemu_ld32s op is only defined if TCG_TARGET_REG_BITS == 64. Your mail client mangled the patch. [..snip..] > @@ -1319,9 +1319,11 @@ static inline void tcg_out_op(TCGContext *s, > int opc, const TCGArg *args, Here. [..snip..] Fixed and applied. --

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Jay Foad
>> --- a/tcg/ppc/tcg-target.c >> +++ b/tcg/ppc/tcg-target.c >> @@ -1693,7 +1693,6 @@ static const TCGTargetOpDef ppc_op_defs[] = { >>      { INDEX_op_qemu_ld16u, { "r", "L" } }, >>      { INDEX_op_qemu_ld16s, { "r", "L" } }, >>      { INDEX_op_qemu_ld32u, { "r", "L" } }, >> -    { INDEX_op_qemu_ld3

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Stefan Weil
Jay Foad schrieb: > The qemu_ld32s op is only defined if TCG_TARGET_REG_BITS == 64. > > Signed-off-by: Jay Foad > --- > tcg/hppa/tcg-target.c |1 - > tcg/ppc/tcg-target.c |2 -- > tcg/sparc/tcg-target.c |4 > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tc

[Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-02-22 Thread Jay Foad
The qemu_ld32s op is only defined if TCG_TARGET_REG_BITS == 64. Signed-off-by: Jay Foad --- tcg/hppa/tcg-target.c |1 - tcg/ppc/tcg-target.c |2 -- tcg/sparc/tcg-target.c |4 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-t