Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-12-10 Thread Wei-Ren Chen
On Mon, Nov 26, 2012 at 08:23:10AM -0800, Richard Henderson wrote: > On 11/24/2012 10:12 AM, Peter Maydell wrote: > > MacOS gcc objects to this: > > In file included from /Users/pm215/src/qemu/tcg/tcg.c:174: > > /Users/pm215/src/qemu/tcg/i386/tcg-target.c:105:19: warning: cpuid.h: > > No such file

Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-26 Thread Richard Henderson
On 11/24/2012 10:12 AM, Peter Maydell wrote: > MacOS gcc objects to this: > In file included from /Users/pm215/src/qemu/tcg/tcg.c:174: > /Users/pm215/src/qemu/tcg/i386/tcg-target.c:105:19: warning: cpuid.h: > No such file or directory > > (though for some reason not as a fatal error). Bizzare. O

Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-25 Thread Aurelien Jarno
On Sat, Nov 24, 2012 at 09:39:35AM -0800, Richard Henderson wrote: > In addition to better compile-time detection, perform runtime detection. > > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.c | 34 +- > tcg/i386/tcg-target.h | 5 - > 2 files

Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-24 Thread Peter Maydell
On 24 November 2012 17:39, Richard Henderson wrote: > --- a/tcg/i386/tcg-target.c > +++ b/tcg/i386/tcg-target.c > @@ -97,6 +97,20 @@ static const int tcg_target_call_oarg_regs[] = { > # define TCG_REG_L1 TCG_REG_EDX > #endif > > +/* Attempt to determine at compile-time whether the compiler assum

[Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-24 Thread Richard Henderson
In addition to better compile-time detection, perform runtime detection. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 34 +- tcg/i386/tcg-target.h | 5 - 2 files changed, 33 insertions(+), 6 deletions(-) Yall are right that there's no particu