On 5 August 2016 at 11:03, Peter Maydell wrote:
> The unlink() function doesn't accept a NULL pointer, so
> don't pass it one. Spotted by the clang sanitizer.
>
> Signed-off-by: Peter Maydell
> ---
> tests/hd-geo-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/
On 6 September 2016 at 20:15, John Snow wrote:
> Well, I know some have religious arguments against making sanitizers happy,
> but that's not my religion.
>
> If some systems appear to think that unlink must take a nonnull argument, I
> think that's a bug -- but making the sanitizer happy doesn't
On 6 September 2016 at 20:06, John Snow wrote:
> On 09/06/2016 08:47 AM, Peter Maydell wrote:
>>
>> Ping?
> Not sure who this belongs to; I can queue it up alongside some IDE and FDC
> stuff in the future if you like.
I can apply it directly; I'd just like review :-)
thanks
-- PMM
On 09/06/2016 03:07 PM, Peter Maydell wrote:
On 6 September 2016 at 20:06, John Snow wrote:
On 09/06/2016 08:47 AM, Peter Maydell wrote:
Ping?
Not sure who this belongs to; I can queue it up alongside some IDE and FDC
stuff in the future if you like.
I can apply it directly; I'd just l
On 09/06/2016 08:47 AM, Peter Maydell wrote:
Ping?
thanks
-- PMM
Not sure who this belongs to; I can queue it up alongside some IDE and
FDC stuff in the future if you like.
--js
On 5 August 2016 at 11:03, Peter Maydell wrote:
The unlink() function doesn't accept a NULL pointer, so
don
Ping?
thanks
-- PMM
On 5 August 2016 at 11:03, Peter Maydell wrote:
> The unlink() function doesn't accept a NULL pointer, so
> don't pass it one. Spotted by the clang sanitizer.
>
> Signed-off-by: Peter Maydell
> ---
> tests/hd-geo-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deleti
On 5 August 2016 at 12:19, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> The unlink() function doesn't accept a NULL pointer, so
>> don't pass it one. Spotted by the clang sanitizer.
>>
>> Signed-off-by: Peter Maydell
>> ---
>> tests/hd-geo-test.c | 4 +++-
>> 1 file changed, 3 insertio
Peter Maydell writes:
> The unlink() function doesn't accept a NULL pointer, so
> don't pass it one. Spotted by the clang sanitizer.
>
> Signed-off-by: Peter Maydell
> ---
> tests/hd-geo-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/hd-geo-test.c b/tes
The unlink() function doesn't accept a NULL pointer, so
don't pass it one. Spotted by the clang sanitizer.
Signed-off-by: Peter Maydell
---
tests/hd-geo-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 12ee392..6176e81
