Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak

2019-03-11 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年3月10日周日 下午10:34写道: > On 3/10/19 12:34 PM, Li Qiang wrote: > > Fixes: 2dbfadf > > ^ Please keep tags together (with Signed-off-by, ...) > > > Spotted by ASAN when 'make check'. > > I'm not native English speaker but I'd say: > > Thanks your advice. Hope the maintain

Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak

2019-03-11 Thread Vladimir Sementsov-Ogievskiy
10.03.2019 14:34, Li Qiang wrote: > Fixes: 2dbfadf > Spotted by ASAN when 'make check'. > > Signed-off-by: Li Qiang Oops, my fault, thank you for fixing this! Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/test-bdrv-graph-mod.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak

2019-03-10 Thread Philippe Mathieu-Daudé
On 3/10/19 12:34 PM, Li Qiang wrote: > Fixes: 2dbfadf ^ Please keep tags together (with Signed-off-by, ...) > Spotted by ASAN when 'make check'. I'm not native English speaker but I'd say: Spotted by ASAN [with] 'make check'. or Spotted by ASAN [while running] 'make check'. Here goes: "Fi

[Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak

2019-03-10 Thread Li Qiang
Fixes: 2dbfadf Spotted by ASAN when 'make check'. Signed-off-by: Li Qiang --- tests/test-bdrv-graph-mod.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c index 458dfa6661..8bf0fe735d 100644 --- a/tests/test-bdrv-graph-mod.c +++ b/test