Re: [Qemu-devel] [PATCH] trace-events: fix broken format strings

2016-01-05 Thread Eric Blake
On 01/05/2016 08:24 AM, Andrew Jones wrote: >> >> I think there are too many quotes. This looks more correct: >> >> "env=%p frame_addr=0x%"PRIx64 > > You're right. The trailing null strings don't break compilation, but don't do > anything either. > > I'll send a v2 with those removed. > No

Re: [Qemu-devel] [PATCH] trace-events: fix broken format strings

2016-01-05 Thread Laurent Vivier
On 05/01/2016 14:20, Andrew Jones wrote: > Fixes compiling with --enable-trace-backends > > Signed-off-by: Andrew Jones > --- > trace-events | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/trace-events b/trace-events > index

Re: [Qemu-devel] [PATCH] trace-events: fix broken format strings

2016-01-05 Thread Andrew Jones
On Tue, Jan 05, 2016 at 03:54:48PM +0100, Laurent Vivier wrote: > > > On 05/01/2016 14:20, Andrew Jones wrote: > > Fixes compiling with --enable-trace-backends > > > > Signed-off-by: Andrew Jones > > --- > > trace-events | 10 +- > > 1 file changed, 5

[Qemu-devel] [PATCH] trace-events: fix broken format strings

2016-01-05 Thread Andrew Jones
Fixes compiling with --enable-trace-backends Signed-off-by: Andrew Jones --- trace-events | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/trace-events b/trace-events index 6f036384a84f8..e42898d5659d5 100644 --- a/trace-events +++