Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-05 Thread Kazuya Saito
(2014/02/04 18:02), Stefan Hajnoczi wrote: On Tue, Feb 04, 2014 at 02:26:13PM +0900, Kazuya Saito wrote: (2014/01/31 19:37), Stefan Hajnoczi wrote: On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: def h(events): +pass I thought all code generation now happens in

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-04 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:24:16PM +0900, Kazuya Saito wrote: (2014/01/31 6:00), Stefan Hajnoczi wrote: On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 175df08..a0addb5 100644 ---

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-04 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:26:13PM +0900, Kazuya Saito wrote: (2014/01/31 19:37), Stefan Hajnoczi wrote: On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: I hope this change can be dropped in the next revision of the patch since the ust backend will no longer be different.

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-03 Thread Kazuya Saito
(2014/01/31 6:00), Stefan Hajnoczi wrote: On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: Some initial comments, I will continue reviewing tomorrow. Thank you for your comment. This patch implements multi tracing backend which enables several tracing backend simultaneously.

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-03 Thread Kazuya Saito
(2014/01/31 19:37), Stefan Hajnoczi wrote: On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: Okay, more feedback after looking at the rest of the patch. Thank you for the feedback. I think ust backend support will simplify the patch a little (see details below). I'll try to

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-01-31 Thread Stefan Hajnoczi
On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: Okay, more feedback after looking at the rest of the patch. I think ust backend support will simplify the patch a little (see details below). Looking forward to the next revision. Let me know if you have any questions about my

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-01-30 Thread Stefan Hajnoczi
On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: Some initial comments, I will continue reviewing tomorrow. This patch implements multi tracing backend which enables several tracing backend simultaneously. QEMU has multiple trace backends, but one of them needs to be chosen at

[Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-01-29 Thread Kazuya Saito
This patch implements multi tracing backend which enables several tracing backend simultaneously. QEMU has multiple trace backends, but one of them needs to be chosen at compile time. When investigating issues of QEMU, it'd be much more convenient if we can use multiple trace backends without