Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-05-05 Thread Andreas Färber
Am 05.05.2013 18:47, schrieb Peter Maydell: > On 5 May 2013 17:29, Andreas Färber wrote: >> That works fine, but one error remains: >> >> LINK i386-softmmu/qemu-system-i386 >> Undefined symbols: >> "___sync_val_compare_and_swap", referenced from: >> _migrate_finish_set_state in migratio

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-05-05 Thread Peter Maydell
On 5 May 2013 17:29, Andreas Färber wrote: > That works fine, but one error remains: > > LINK i386-softmmu/qemu-system-i386 > Undefined symbols: > "___sync_val_compare_and_swap", referenced from: > _migrate_finish_set_state in migration.o > ld: symbol(s) not found > collect2: ld returne

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-05-05 Thread Andreas Färber
Am 22.04.2013 14:32, schrieb Paolo Bonzini: > Il 22/04/2013 13:51, Peter Maydell ha scritto: >> On 22 April 2013 00:03, Andreas Färber wrote: >>> Even after this has been applied, things are still not building for me. >>> >>> I'm seeing CC trace/generated-events.o failing with "error: parameter >>

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-22 Thread Paolo Bonzini
Il 22/04/2013 13:51, Peter Maydell ha scritto: > On 22 April 2013 00:03, Andreas Färber wrote: >> Even after this has been applied, things are still not building for me. >> >> I'm seeing CC trace/generated-events.o failing with "error: parameter >> name omitted" for trace_apic_local_deliver, trace

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-22 Thread Peter Maydell
On 22 April 2013 00:03, Andreas Färber wrote: > Even after this has been applied, things are still not building for me. > > I'm seeing CC trace/generated-events.o failing with "error: parameter > name omitted" for trace_apic_local_deliver, trace_usb_xhci_queue_event, > trace_megasas_msix_raise and

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-21 Thread Andreas Färber
Peter, Am 21.04.2013 11:54, schrieb Peter Maydell: > Early ping for compile-breakage fix patch (ccing Blue this time > round since you've been applying patches this weekend.) > > Patchwork url: http://patchwork.ozlabs.org/patch/237347/ Even after this has been applied, things are still not build

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-21 Thread Blue Swirl
Thanks, applied. On Sun, Apr 21, 2013 at 9:54 AM, Peter Maydell wrote: > Early ping for compile-breakage fix patch (ccing Blue this time > round since you've been applying patches this weekend.) > > Patchwork url: http://patchwork.ozlabs.org/patch/237347/ > > thanks! > -- PMM > > On 17 April 2013

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-21 Thread Peter Maydell
Early ping for compile-breakage fix patch (ccing Blue this time round since you've been applying patches this weekend.) Patchwork url: http://patchwork.ozlabs.org/patch/237347/ thanks! -- PMM On 17 April 2013 20:16, Peter Maydell wrote: > Fix failures to compile introduced by recent console com

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-17 Thread Gerd Hoffmann
On 04/17/13 21:16, Peter Maydell wrote: > Fix failures to compile introduced by recent console commits > 1dbfa00503, 81c0d5a6) which removed is_graphic_console() and > vga_hw_update() without updating the cocoa UI backend to match. > > Signed-off-by: Peter Maydell Reviewed-by: Gerd Hoffmann ch

[Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-17 Thread Peter Maydell
Fix failures to compile introduced by recent console commits 1dbfa00503, 81c0d5a6) which removed is_graphic_console() and vga_hw_update() without updating the cocoa UI backend to match. Signed-off-by: Peter Maydell --- ui/cocoa.m | 8 1 file changed, 4 insertions(+), 4 deletions(-) dif