Eric Blake writes:
> On 03/01/2016 06:20 PM, Programmingkid wrote:
>
>>> You weren't the original cause of the bug, so it is not necessarily this
>>> patch's job to fix the bug. Therefore, "pre-existing". But since the
>>> bug was observed during review of your patch, you may want to fix it
>>>
On 03/01/2016 06:20 PM, Programmingkid wrote:
>> You weren't the original cause of the bug, so it is not necessarily this
>> patch's job to fix the bug. Therefore, "pre-existing". But since the
>> bug was observed during review of your patch, you may want to fix it
>> anyways, probably as a sepa
On Mar 1, 2016, at 7:25 PM, Eric Blake wrote:
> On 03/01/2016 05:12 PM, Programmingkid wrote:
>
>>>
+
+[MAC_KEY_ESC] = Q_KEY_CODE_ESC,
+//[MAC_KEY_F1] = Q_KEY_CODE_POWER, // Just in case you need the power
key
+[MAC_KEY_F1] = Q_KEY_CODE_F1,
>>>
>>> The com
On 03/01/2016 05:12 PM, Programmingkid wrote:
>>
>>> +
>>> +[MAC_KEY_ESC] = Q_KEY_CODE_ESC,
>>> +//[MAC_KEY_F1] = Q_KEY_CODE_POWER, // Just in case you need the power
>>> key
>>> +[MAC_KEY_F1] = Q_KEY_CODE_F1,
>>
>> The comment looks weird. Probably worth a mention in the commit messa
On Mar 1, 2016, at 6:18 PM, Peter Maydell wrote:
> On 1 March 2016 at 22:12, Programmingkid wrote:
>> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode
>> layout.
>>
>> Signed-off-by: John Arbuckle
>>
>> ---
>> Maintainer note:
>> Please apply these patches before test
On Mar 1, 2016, at 6:16 PM, Eric Blake wrote:
> On 03/01/2016 03:12 PM, Programmingkid wrote:
>> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode
>> layout.
>>
>> Signed-off-by: John Arbuckle
>>
>> ---
>> Maintainer note:
>> Please apply these patches before testing:
On 1 March 2016 at 22:12, Programmingkid wrote:
> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode
> layout.
>
> Signed-off-by: John Arbuckle
>
> ---
> Maintainer note:
> Please apply these patches before testing:
> - qapi-schema.json: Add kp_equals and power keys
> - adb
On 03/01/2016 03:12 PM, Programmingkid wrote:
> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode
> layout.
>
> Signed-off-by: John Arbuckle
>
> ---
> Maintainer note:
> Please apply these patches before testing:
> - qapi-schema.json: Add kp_equals and power keys
> - adb
The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode
layout.
Signed-off-by: John Arbuckle
---
Maintainer note:
Please apply these patches before testing:
- qapi-schema.json: Add kp_equals and power keys
- adb.c: Replace pc_to_adb_keycode with more detailed array
- MacKeys.h
