Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-11 Thread Gerd Hoffmann
On Mon, Jan 07, 2019 at 10:35:30AM +, Peter Maydell wrote: > On Mon, 7 Jan 2019 at 10:22, Gerd Hoffmann wrote: > > > > On Thu, Jan 03, 2019 at 05:31:13AM -0800, Li Qiang wrote: > > > Spotted by Coverity: CID 1397070 > > > > #ifdef CONFIG_INOTIFY1 > > > @@ -682,6 +683,7 @@ static void

Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-07 Thread Peter Maydell
On Mon, 7 Jan 2019 at 10:22, Gerd Hoffmann wrote: > > On Thu, Jan 03, 2019 at 05:31:13AM -0800, Li Qiang wrote: > > Spotted by Coverity: CID 1397070 > > #ifdef CONFIG_INOTIFY1 > > @@ -682,6 +683,7 @@ static void usb_mtp_object_readdir(MTPState *s, > > MTPObject *o) > >

Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-07 Thread Gerd Hoffmann
On Thu, Jan 03, 2019 at 05:31:13AM -0800, Li Qiang wrote: > Spotted by Coverity: CID 1397070 > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index b19b576278..666bafd9e8 100644 > --- a/hw/usb/dev-mtp.c > +++ b/hw/usb/dev-mtp.c > @@ -666,6 +666,7 @@ static void usb_mtp_object_readdir(MTPState

Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-03 Thread Philippe Mathieu-Daudé
On 1/3/19 2:31 PM, Li Qiang wrote: > Spotted by Coverity: CID 1397070 Closing a CVE to open a CID :) Fixes: bab9df35ce > > Signed-off-by: Li Qiang > --- > hw/usb/dev-mtp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index

[Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-03 Thread Li Qiang
Spotted by Coverity: CID 1397070 Signed-off-by: Li Qiang --- hw/usb/dev-mtp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index b19b576278..666bafd9e8 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -666,6 +666,7 @@ static void