Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Gonglei (Arei)
> >> > --- > >> > hw/usb/dev-storage.c | 11 ++- > >> > 1 file changed, 6 insertions(+), 5 deletions(-) > >> > > >> > diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c > >> > index 5c51ac0..cabd053 100644 > >> > --- a/hw/usb/dev-storage.c > >> > +++ b/hw/usb/dev-storage.c > >> > @@

Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Markus Armbruster
"Gonglei (Arei)" writes: >> From: Markus Armbruster [mailto:arm...@redhat.com] >> Sent: Thursday, September 18, 2014 3:38 PM >> Subject: Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and >> missing error message >> >>

Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, September 18, 2014 3:38 PM > Subject: Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and > missing error message > > writes: > > > From: Gonglei > > > > When

Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Markus Armbruster
writes: > From: Gonglei > > When scsi_bus_legacy_add_drive() return NULL, meanwhile err will > be not NULL, which will casue memory leak and missing error message. > > Signed-off-by: Gonglei > --- > hw/usb/dev-storage.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > di

[Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-17 Thread arei.gonglei
From: Gonglei When scsi_bus_legacy_add_drive() return NULL, meanwhile err will be not NULL, which will casue memory leak and missing error message. Signed-off-by: Gonglei --- hw/usb/dev-storage.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/usb/dev-storage