Re: [Qemu-devel] [PATCH] util/hbitmaps: recalculate count on merge

2018-09-27 Thread John Snow
On 09/27/2018 10:09 AM, Eric Blake wrote: > On 9/27/18 2:31 AM, Vladimir Sementsov-Ogievskiy wrote: >> 27.09.2018 00:28, John Snow wrote: >>> We have been neglecting to do so, which results in wrong counts >>> after merge. In the worst case, we may think the bitmap is empty >>> when it has had

Re: [Qemu-devel] [PATCH] util/hbitmaps: recalculate count on merge

2018-09-27 Thread Eric Blake
On 9/27/18 2:31 AM, Vladimir Sementsov-Ogievskiy wrote: 27.09.2018 00:28, John Snow wrote: We have been neglecting to do so, which results in wrong counts after merge. In the worst case, we may think the bitmap is empty when it has had new writes merged into it. Reported-by: Eric Blake

Re: [Qemu-devel] [PATCH] util/hbitmaps: recalculate count on merge

2018-09-27 Thread Vladimir Sementsov-Ogievskiy
27.09.2018 00:28, John Snow wrote: We have been neglecting to do so, which results in wrong counts after merge. In the worst case, we may think the bitmap is empty when it has had new writes merged into it. Reported-by: Eric Blake Signed-off-by: John Snow --- util/hbitmap.c | 3 +++ 1 file

[Qemu-devel] [PATCH] util/hbitmaps: recalculate count on merge

2018-09-26 Thread John Snow
We have been neglecting to do so, which results in wrong counts after merge. In the worst case, we may think the bitmap is empty when it has had new writes merged into it. Reported-by: Eric Blake Signed-off-by: John Snow --- util/hbitmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git