Re: [Qemu-devel] [PATCH] vfio: Fix regression in MSI routing configuration

2016-09-19 Thread David Gibson
On Sun, Sep 18, 2016 at 01:33:27PM +0800, Peter Xu wrote: > Good to know that we have a solution. :) > > I think this is a good fix, however I still do not understand why this > is happening... Please see below comment. > > On Thu, Sep 15, 2016 at 04:11:48PM +1000, David Gibson wrote: > > d1f6af6

Re: [Qemu-devel] [PATCH] vfio: Fix regression in MSI routing configuration

2016-09-17 Thread Peter Xu
Good to know that we have a solution. :) I think this is a good fix, however I still do not understand why this is happening... Please see below comment. On Thu, Sep 15, 2016 at 04:11:48PM +1000, David Gibson wrote: > d1f6af6 "kvm-irqchip: simplify kvm_irqchip_add_msi_route" was a cleanup > of kv

Re: [Qemu-devel] [PATCH] vfio: Fix regression in MSI routing configuration

2016-09-15 Thread Alex Williamson
On Thu, 15 Sep 2016 16:11:48 +1000 David Gibson wrote: > d1f6af6 "kvm-irqchip: simplify kvm_irqchip_add_msi_route" was a cleanup > of kvmchip routing configuration, that was mostly intended for x86. > However, it also contains a subtle change in behaviour which breaks EEH[1] > error recovery on c

[Qemu-devel] [PATCH] vfio: Fix regression in MSI routing configuration

2016-09-14 Thread David Gibson
d1f6af6 "kvm-irqchip: simplify kvm_irqchip_add_msi_route" was a cleanup of kvmchip routing configuration, that was mostly intended for x86. However, it also contains a subtle change in behaviour which breaks EEH[1] error recovery on certain VFIO passthrough devices on spapr guests. So far it's onl