Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs

2018-10-23 Thread Michael S. Tsirkin
On Tue, Oct 23, 2018 at 01:49:16AM +0200, Philippe Mathieu-Daudé wrote: > On 22/10/18 4:17, yuchenlin via Qemu-devel wrote: > > Ping? > > > > On 2018-10-12 17:07, yuchen...@synology.com wrote: > > > From: yuchenlin > > > > > > There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,

Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs

2018-10-22 Thread Philippe Mathieu-Daudé
On 22/10/18 4:17, yuchenlin via Qemu-devel wrote: Ping? On 2018-10-12 17:07, yuchen...@synology.com wrote: From: yuchenlin There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device, but seabios will only set the physical address for the 3rd one (cmd). Then in vhost_virtqueue_start()

Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs

2018-10-21 Thread yuchenlin via Qemu-devel
Ping? On 2018-10-12 17:07, yuchen...@synology.com wrote: From: yuchenlin There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device, but seabios will only set the physical address for the 3rd one (cmd). Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr() will be 0 for ctrl a

[Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs

2018-10-12 Thread yuchenlin--- via Qemu-devel
From: yuchenlin There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device, but seabios will only set the physical address for the 3rd one (cmd). Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr() will be 0 for ctrl and event vq. In this case, ctrl and event vq are not initia