Re: [Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-18 Thread shesha Sreenivasamurthy (shesha)
Got it. Thanks, I missed that line while reading the spec. Is docs/specs/vhost-user.txt the official spec ? -- - Thanks char * (*shesha) (uint64_t cache, uint8_t F00D) { return 0xC0DE; } From: "Michael S. Tsirkin" mailto:m...@redhat.com>> Date: Sunday, January 17, 2016 at 3:23 AM To: Cisco E

Re: [Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-17 Thread Michael S. Tsirkin
On Fri, Jan 15, 2016 at 12:12:44PM -0800, Shesha Sreenivasamurthy wrote: > Send VHOST_USER_RESET_OWNER when the device is stopped. > > Signed-off-by: Shesha Sreenivasamurthy That's a bad commit log. A good one should describe why changes are made, not what they are (that can be seen from the ch

Re: [Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-17 Thread Michael S. Tsirkin
On Fri, Jan 15, 2016 at 12:12:43PM -0800, Shesha Sreenivasamurthy wrote: > Problem: > > If a guest has vhost-user enabled, then on reboot vhost_virtqueue_stop > is invoked. This unmaps vring memory mappings. However, it will not give > any indication to the underlying DPDK slave applicatio

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Send VHOST_USER_RESET_OWNER when the device is stopped. Signed-off-by: Shesha Sreenivasamurthy --- hw/virtio/vhost.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index de29968..808184f 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -12

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Problem: If a guest has vhost-user enabled, then on reboot vhost_virtqueue_stop is invoked. This unmaps vring memory mappings. However, it will not give any indication to the underlying DPDK slave application about it. Therefore, a pollmode DPDK driver tries to read the ring to check for p

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Problem: If a guest has vhost-user enabled, then on reboot vhost_virtqueue_stop is invoked. This unmaps vring memory mappings. However, it will not give any indication to the underlying DPDK slave application about it. Therefore, a pollmode DPDK driver tries to read the ring to check for p

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Send VHOST_USER_RESET_OWNER when the device is stopped. Signed-off-by: Shesha Sreenivasamurthy --- hw/virtio/vhost.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index de29968..808184f 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -12