Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-12 Thread Michael S. Tsirkin
On Wed, Nov 11, 2015 at 04:33:05PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Nov 11, 2015 at 3:26 PM, Victor Kaplansky wrote: > > > > - Sets the logging base address. > > + Sets logging shared memory space. > > + When slave has VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol > > +

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Marc-André Lureau
Hi On Wed, Nov 11, 2015 at 3:26 PM, Victor Kaplansky wrote: > > - Sets the logging base address. > + Sets logging shared memory space. > + When slave has VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol > + feature, the log memory fd is provided in the ancillary data of > + VHOST

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Michael S. Tsirkin
On Wed, Nov 11, 2015 at 04:23:33PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Nov 11, 2015 at 4:17 PM, Michael S. Tsirkin wrote: > > Remote doesn't know the size though, and offset is only there > > in the current implementation. > > It can compute the size based on the mem tables. But it

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Marc-André Lureau
Hi On Wed, Nov 11, 2015 at 4:17 PM, Michael S. Tsirkin wrote: > Remote doesn't know the size though, and offset is only there > in the current implementation. It can compute the size based on the mem tables. But it could be more future-proof to add these informations. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Michael S. Tsirkin
On Wed, Nov 11, 2015 at 09:32:17AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > Unlike the kernel, vhost-user application accesses log table by > > mmaping it to its user space. This change adds two new fields to > > VhostUserMsg payload: mmap_size, and mmap_offset and

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Marc-André Lureau
Hi - Original Message - > Unlike the kernel, vhost-user application accesses log table by > mmaping it to its user space. This change adds two new fields to > VhostUserMsg payload: mmap_size, and mmap_offset and make QEMU to > pass the to vhost-user application in VHOST_USER_SET_LOG_BASE >

[Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Victor Kaplansky
Unlike the kernel, vhost-user application accesses log table by mmaping it to its user space. This change adds two new fields to VhostUserMsg payload: mmap_size, and mmap_offset and make QEMU to pass the to vhost-user application in VHOST_USER_SET_LOG_BASE request. Signed-off-by: Victor Kaplansky