Re: [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long

2014-09-24 Thread Fam Zheng
On Wed, 09/24 05:44, Peter Maydell wrote: > On 24 September 2014 01:46, Fam Zheng wrote: > > On Wed, 09/24 07:20, Stefan Weil wrote: > >> Compiler warning (w32, w64): > >> > >> include/hw/virtio/virtio_ring.h:142:26: warning: > >> cast from pointer to integer of different size [-Wpointer-to-int-c

Re: [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long

2014-09-24 Thread Peter Maydell
On 24 September 2014 01:46, Fam Zheng wrote: > On Wed, 09/24 07:20, Stefan Weil wrote: >> Compiler warning (w32, w64): >> >> include/hw/virtio/virtio_ring.h:142:26: warning: >> cast from pointer to integer of different size [-Wpointer-to-int-cast] >> >> When sizeof(long) < sizeof(void *), this is

Re: [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long

2014-09-24 Thread Stefan Hajnoczi
On Wed, Sep 24, 2014 at 07:20:02AM +0200, Stefan Weil wrote: > Compiler warning (w32, w64): > > include/hw/virtio/virtio_ring.h:142:26: warning: > cast from pointer to integer of different size [-Wpointer-to-int-cast] > > When sizeof(long) < sizeof(void *), this is not only a warning but a > rea

Re: [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long

2014-09-24 Thread Fam Zheng
On Wed, 09/24 07:20, Stefan Weil wrote: > Compiler warning (w32, w64): > > include/hw/virtio/virtio_ring.h:142:26: warning: > cast from pointer to integer of different size [-Wpointer-to-int-cast] > > When sizeof(long) < sizeof(void *), this is not only a warning but a > real program error. > >

Re: [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long

2014-09-24 Thread Markus Armbruster
Stefan Weil writes: > Compiler warning (w32, w64): > > include/hw/virtio/virtio_ring.h:142:26: warning: > cast from pointer to integer of different size [-Wpointer-to-int-cast] > > When sizeof(long) < sizeof(void *), this is not only a warning but a > real program error. > > Add also missing bla

[Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long

2014-09-23 Thread Stefan Weil
Compiler warning (w32, w64): include/hw/virtio/virtio_ring.h:142:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] When sizeof(long) < sizeof(void *), this is not only a warning but a real program error. Add also missing blanks in the same statement. Signed-of