Re: [Qemu-devel] [PATCH] virtio: add missing mb() on notification

2012-04-23 Thread Stefan Hajnoczi
On Sun, Apr 22, 2012 at 3:54 PM, Michael S. Tsirkin wrote: > During normal operation, virtio host first writes a used index > and then checks whether it should interrupt the guest > by reading guest avail flag/used event index values. > Guest does the reverse: writes the index/flag, > then checks

[Qemu-devel] [PATCH] virtio: add missing mb() on notification

2012-04-22 Thread Michael S. Tsirkin
During normal operation, virtio host first writes a used index and then checks whether it should interrupt the guest by reading guest avail flag/used event index values. Guest does the reverse: writes the index/flag, then checks the used ring. The ordering is important: if host avail flag read byp