Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 01:48:44AM +0100, Andreas Färber wrote: Am 18.12.2012 01:30, schrieb Michael S. Tsirkin: On Tue, Dec 18, 2012 at 01:13:18AM +0100, Andreas Färber wrote: Am 17.12.2012 23:58, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote:

[Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Michael S. Tsirkin
Move bindings from opaque to DeviceState. This gives us better type safety with no performance cost. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/s390-virtio-bus.c | 8 hw/virtio-pci.c | 48 hw/virtio.h | 24

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Andreas Färber
Am 17.12.2012 16:45, schrieb Michael S. Tsirkin: diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 3ea4140..63ae888 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -98,34 +98,34 @@ bool virtio_is_big_endian(void); /* virtio device */ -static void virtio_pci_notify(void

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Paolo Bonzini
Il 17/12/2012 18:55, Andreas Färber ha scritto: Am 17.12.2012 16:45, schrieb Michael S. Tsirkin: diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 3ea4140..63ae888 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -98,34 +98,34 @@ bool virtio_is_big_endian(void); /* virtio device

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Andreas Färber
Am 17.12.2012 19:21, schrieb Paolo Bonzini: Il 17/12/2012 18:55, Andreas Färber ha scritto: Am 17.12.2012 16:45, schrieb Michael S. Tsirkin: diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 3ea4140..63ae888 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -98,34 +98,34 @@ bool

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote: Am 17.12.2012 19:21, schrieb Paolo Bonzini: Il 17/12/2012 18:55, Andreas Färber ha scritto: Am 17.12.2012 16:45, schrieb Michael S. Tsirkin: diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 3ea4140..63ae888 100644 ---

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 06:55:46PM +0100, Andreas Färber wrote: Am 17.12.2012 16:45, schrieb Michael S. Tsirkin: diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 3ea4140..63ae888 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -98,34 +98,34 @@ bool virtio_is_big_endian(void);

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Andreas Färber
Am 17.12.2012 21:48, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote: Am 17.12.2012 19:21, schrieb Paolo Bonzini: Il 17/12/2012 18:55, Andreas Färber ha scritto: Am 17.12.2012 16:45, schrieb Michael S. Tsirkin: diff --git a/hw/virtio-pci.c

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote: Am 17.12.2012 21:48, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote: Am 17.12.2012 19:21, schrieb Paolo Bonzini: Il 17/12/2012 18:55, Andreas Färber ha scritto: Am 17.12.2012 16:45,

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Andreas Färber
Am 17.12.2012 22:18, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote: Am 17.12.2012 21:48, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote: Am 17.12.2012 19:21, schrieb Paolo Bonzini: Il 17/12/2012 18:55,

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote: Am 17.12.2012 22:18, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote: Am 17.12.2012 21:48, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote:

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Andreas Färber
Am 17.12.2012 23:58, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote: Am 17.12.2012 22:18, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote: Am 17.12.2012 21:48, schrieb Michael S. Tsirkin: On Mon, Dec 17,

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 01:13:18AM +0100, Andreas Färber wrote: Am 17.12.2012 23:58, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote: Am 17.12.2012 22:18, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote:

Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe

2012-12-17 Thread Andreas Färber
Am 18.12.2012 01:30, schrieb Michael S. Tsirkin: On Tue, Dec 18, 2012 at 01:13:18AM +0100, Andreas Färber wrote: Am 17.12.2012 23:58, schrieb Michael S. Tsirkin: On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote: Am 17.12.2012 22:18, schrieb Michael S. Tsirkin: On Mon, Dec 17,