[Qemu-devel] [PATCH] virtio: move sanity checks to ifdef DEBUG

2015-03-18 Thread Michael S. Tsirkin
All that happens when virtqueue_fill is invoked incorrectly is that we corrupt guest memory, so this check is not a security measure. Move the check to ifdef DEBUG to make sure we don't introduce new crashes close to release. Array scans aren't free either, so it's a good idea from performance poin

Re: [Qemu-devel] [PATCH] virtio: move sanity checks to ifdef DEBUG

2015-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2015 12:42:46 +0100 "Michael S. Tsirkin" wrote: > All that happens when virtqueue_fill is invoked incorrectly is that we > corrupt guest memory, so this check is not a security measure. > Move the check to ifdef DEBUG to make sure we don't introduce new > crashes close to release.