Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
On 02/20/2014 02:47 PM, Peter Maydell wrote: > On 20 February 2014 22:36, Mario Smarduch wrote: >> On 02/20/2014 02:10 PM, Peter Maydell wrote: >>> On 20 February 2014 21:59, Mario Smarduch wrote: On 02/20/2014 11:35 AM, Peter Maydell wrote: > On 20 February 2014 19:09, Mario Smarduch w

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Peter Maydell
On 20 February 2014 22:36, Mario Smarduch wrote: > On 02/20/2014 02:10 PM, Peter Maydell wrote: >> On 20 February 2014 21:59, Mario Smarduch wrote: >>> On 02/20/2014 11:35 AM, Peter Maydell wrote: On 20 February 2014 19:09, Mario Smarduch wrote: > host features since you don't know what

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
On 02/20/2014 02:10 PM, Peter Maydell wrote: > On 20 February 2014 21:59, Mario Smarduch wrote: >> On 02/20/2014 11:35 AM, Peter Maydell wrote: >>> On 20 February 2014 19:09, Mario Smarduch wrote: host features since you don't know what virtio device will be plugged in later. >>> >>> I

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Peter Maydell
On 20 February 2014 21:59, Mario Smarduch wrote: > On 02/20/2014 11:35 AM, Peter Maydell wrote: >> On 20 February 2014 19:09, Mario Smarduch wrote: >>> host features since you don't know what virtio device will be plugged >>> in later. >> >> I think this function is the right place to set these p

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
On 02/20/2014 11:35 AM, Peter Maydell wrote: > On 20 February 2014 19:09, Mario Smarduch wrote: >> host features since you don't know what virtio device will be plugged >> in later. > > I think this function is the right place to set these properties, > yes. What I'm saying is that I don't see wh

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Peter Maydell
On 20 February 2014 19:09, Mario Smarduch wrote: > Questionable in this patch - is cutting through several layers to set > proxy properties. They should be set from "device" instance init > before it's realized. The problem though is that unlike PCI > that sets proxy and virtio-net properties via

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
Peter thanks. Questionable in this patch - is cutting through several layers to set proxy properties. They should be set from "device" instance init before it's realized. The problem though is that unlike PCI that sets proxy and virtio-net properties via its virtio_net_properites[], the virtio-mmi

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Peter Maydell
On 20 February 2014 18:12, Mario Smarduch wrote: > > Hello, > > any feedback on this patch, after a brief email exchange Anthony deferred to > Peter. > > Lack of improper host features handling lowers 1g & 10g performance > substantially on arm-kvm compared to xeon. > > We would like to have this

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
Hello, any feedback on this patch, after a brief email exchange Anthony deferred to Peter. Lack of improper host features handling lowers 1g & 10g performance substantially on arm-kvm compared to xeon. We would like to have this fixed so we don't have to patch every new release of qemu, espe

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-14 Thread Peter Maydell
CCing the virtio maintainers. thanks -- PMM On 13 February 2014 21:13, Mario Smarduch wrote: > virtio: set virtio-net/virtio-mmio host features > > Patch sets 'virtio-net/virtio-mmio' host features to enable network > features based on peer capabilities. Currently host features turn > of all fea

[Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-13 Thread Mario Smarduch
virtio: set virtio-net/virtio-mmio host features Patch sets 'virtio-net/virtio-mmio' host features to enable network features based on peer capabilities. Currently host features turn of all features by default. Signed-off-by: Mario Smarduch --- hw/virtio/virtio-mmio.c | 29 +++