Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-16 Thread Luiz Capitulino
On Tue, 16 Sep 2014 15:43:14 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Tue, 16 Sep 2014 09:25:02 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > When a QMP client changes the polling interval time by setting > >> > the guest-stats-polli

Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-16 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 16 Sep 2014 09:25:02 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > When a QMP client changes the polling interval time by setting >> > the guest-stats-polling-interval property, the interval value >> > is stored and manipuled as an int6

Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-16 Thread Luiz Capitulino
On Tue, 16 Sep 2014 09:25:02 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > When a QMP client changes the polling interval time by setting > > the guest-stats-polling-interval property, the interval value > > is stored and manipuled as an int64_t variable. > > > > However, the b

Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-16 Thread Markus Armbruster
Luiz Capitulino writes: > When a QMP client changes the polling interval time by setting > the guest-stats-polling-interval property, the interval value > is stored and manipuled as an int64_t variable. > > However, the balloon_stats_change_timer() function, which is > used to set the actual time

Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-15 Thread Luiz Capitulino
On Mon, 15 Sep 2014 13:16:01 -0600 Eric Blake wrote: > On 09/15/2014 12:09 PM, Luiz Capitulino wrote: > > When a QMP client changes the polling interval time by setting > > the guest-stats-polling-interval property, the interval value > > is stored and manipuled as an int64_t variable. > > > >

Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-15 Thread Eric Blake
On 09/15/2014 12:09 PM, Luiz Capitulino wrote: > When a QMP client changes the polling interval time by setting > the guest-stats-polling-interval property, the interval value > is stored and manipuled as an int64_t variable. > s/manipuled/manipulated/ > However, the balloon_stats_change_timer()

[Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature

2014-09-15 Thread Luiz Capitulino
When a QMP client changes the polling interval time by setting the guest-stats-polling-interval property, the interval value is stored and manipuled as an int64_t variable. However, the balloon_stats_change_timer() function, which is used to set the actual timer with the interval value, takes an i