Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread KONRAD Frédéric
On 12/04/2013 11:14, Peter Maydell wrote: On 12 April 2013 09:36, KONRAD Frédéric wrote: On 12/04/2013 10:29, Peter Maydell wrote: Does the approach I suggested on IRC where virtio-balloon-pci's property set/get callbacks just set/get the property on virtio-balloon via the public interface not

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread KONRAD Frédéric
On 12/04/2013 11:14, Peter Maydell wrote: On 12 April 2013 09:36, KONRAD Frédéric wrote: On 12/04/2013 10:29, Peter Maydell wrote: Does the approach I suggested on IRC where virtio-balloon-pci's property set/get callbacks just set/get the property on virtio-balloon via the public interface not

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread Peter Maydell
On 12 April 2013 09:36, KONRAD Frédéric wrote: > On 12/04/2013 10:29, Peter Maydell wrote: >> Does the approach I suggested on IRC where virtio-balloon-pci's >> property set/get callbacks just set/get the property on >> virtio-balloon via the public interface not work? Having to >> expose virtio-b

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread KONRAD Frédéric
On 12/04/2013 10:29, Peter Maydell wrote: On 11 April 2013 23:38, wrote: From: KONRAD Frederic To keep compatibility with the old virtio-balloon-x, add the dynamic properties to virtio-balloon-pci and virtio-balloon-ccw. Does the approach I suggested on IRC where virtio-balloon-pci's proper

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread Peter Maydell
On 11 April 2013 23:38, wrote: > From: KONRAD Frederic > > To keep compatibility with the old virtio-balloon-x, add the dynamic > properties > to virtio-balloon-pci and virtio-balloon-ccw. Does the approach I suggested on IRC where virtio-balloon-pci's property set/get callbacks just set/get t

[Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-11 Thread fred . konrad
From: KONRAD Frederic To keep compatibility with the old virtio-balloon-x, add the dynamic properties to virtio-balloon-pci and virtio-balloon-ccw. Cc: Luiz Capitulino Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 8 hw/virtio/virtio-balloon.c | 16