Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-03-06 Thread Sergio Lopez
Kevin Wolf writes: > Am 01.03.2019 um 14:47 hat Sergio Lopez geschrieben: >> >> Otherwise, we can simply add an extra condition at >> >> child_job_drained_poll(), before the drv->drained_poll(), to return >> >> true if the job isn't yet paused. >> > >> > Yes, I think something like this is this

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-03-01 Thread Kevin Wolf
Am 01.03.2019 um 14:47 hat Sergio Lopez geschrieben: > >> Otherwise, we can simply add an extra condition at > >> child_job_drained_poll(), before the drv->drained_poll(), to return > >> true if the job isn't yet paused. > > > > Yes, I think something like this is this right fix. > > Fixing this h

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-03-01 Thread Sergio Lopez
Kevin Wolf writes: > Am 28.02.2019 um 19:36 hat Sergio Lopez geschrieben: >> On Thu, Feb 28, 2019 at 06:22:02PM +0100, Kevin Wolf wrote: >> > Am 28.02.2019 um 18:04 hat Sergio Lopez geschrieben: >> > > On Thu, Feb 28, 2019 at 04:50:53PM +0100, Kevin Wolf wrote: >> > > > Am 28.02.2019 um 16:01 ha

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-03-01 Thread Kevin Wolf
Am 28.02.2019 um 19:36 hat Sergio Lopez geschrieben: > On Thu, Feb 28, 2019 at 06:22:02PM +0100, Kevin Wolf wrote: > > Am 28.02.2019 um 18:04 hat Sergio Lopez geschrieben: > > > On Thu, Feb 28, 2019 at 04:50:53PM +0100, Kevin Wolf wrote: > > > > Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben:

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-02-28 Thread Sergio Lopez
On Thu, Feb 28, 2019 at 06:22:02PM +0100, Kevin Wolf wrote: > Am 28.02.2019 um 18:04 hat Sergio Lopez geschrieben: > > On Thu, Feb 28, 2019 at 04:50:53PM +0100, Kevin Wolf wrote: > > > Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben: > > > > On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-02-28 Thread Kevin Wolf
Am 28.02.2019 um 18:04 hat Sergio Lopez geschrieben: > On Thu, Feb 28, 2019 at 04:50:53PM +0100, Kevin Wolf wrote: > > Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben: > > > On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf wrote: > > > > Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben:

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-02-28 Thread Sergio Lopez
On Thu, Feb 28, 2019 at 04:50:53PM +0100, Kevin Wolf wrote: > Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben: > > On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf wrote: > > > Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben: > > > > Stopping the dataplane requires calling to blk_set_ai

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-02-28 Thread Kevin Wolf
Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben: > On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf wrote: > > Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben: > > > Stopping the dataplane requires calling to blk_set_aio_context, which > > > may need to wait for a running job to be comp

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-02-28 Thread Sergio Lopez
On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf wrote: > Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben: > > Stopping the dataplane requires calling to blk_set_aio_context, which > > may need to wait for a running job to be completed or paused. > > > > As stopping the dataplane is someth

Re: [Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-02-27 Thread Kevin Wolf
Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben: > Stopping the dataplane requires calling to blk_set_aio_context, which > may need to wait for a running job to be completed or paused. > > As stopping the dataplane is something that can be triggered from a vcpu > thread (due to the Guest reque

[Qemu-devel] [PATCH] virtio-blk: dataplane: release AioContext before blk_set_aio_context

2019-02-27 Thread Sergio Lopez
Stopping the dataplane requires calling to blk_set_aio_context, which may need to wait for a running job to be completed or paused. As stopping the dataplane is something that can be triggered from a vcpu thread (due to the Guest requesting to stop the device), while the job itself may be managed