Re: [Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

2017-11-09 Thread 吴涛@Eng
Thanks. Sent out a new version add comments to say that we rely on pixman create_bits to fail. On Thu, Nov 9, 2017 at 2:34 AM, Marc-André Lureau wrote: > Hi > > - Original Message - >> The old code treats bits as bytes when calculating host memory usage. >> Change it to be consistent with

Re: [Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

2017-11-09 Thread Marc-André Lureau
On Thu, Nov 9, 2017 at 7:17 PM, Tao Wu via Qemu-devel wrote: > The old code treats bits as bytes when calculating host memory usage. > Change it to be consistent with allocation logic in pixman library. > > Signed-off-by: Tao Wu Reviewed-by: Marc-André Lureau > --- > hw/display/virtio-gpu.c |

[Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

2017-11-09 Thread Tao Wu via Qemu-devel
The old code treats bits as bytes when calculating host memory usage. Change it to be consistent with allocation logic in pixman library. Signed-off-by: Tao Wu --- hw/display/virtio-gpu.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/display/virtio-gpu.

Re: [Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

2017-11-09 Thread Marc-André Lureau
Hi - Original Message - > The old code treats bits as bytes when calculating host memory usage. > Change it to be consistent with allocation logic in pixman library. > Good catch > Signed-off-by: Tao Wu > --- > hw/display/virtio-gpu.c | 13 +++-- > 1 file changed, 11 insertion

[Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

2017-11-08 Thread Tao Wu via Qemu-devel
The old code treats bits as bytes when calculating host memory usage. Change it to be consistent with allocation logic in pixman library. Signed-off-by: Tao Wu --- hw/display/virtio-gpu.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/display/virtio-gpu.c b