Re: [Qemu-devel] [PATCH] virtio-net: Don't pass NULL peer to tap routines

2010-09-26 Thread Michael S. Tsirkin
On Fri, Sep 24, 2010 at 08:17:09AM -0600, Alex Williamson wrote: > On Fri, 2010-09-24 at 11:31 +0200, Markus Armbruster wrote: > > Alex Williamson writes: > > > > > On Thu, 2010-09-23 at 12:43 -0500, Anthony Liguori wrote: > > >> On 09/22/2010 02:52 PM, Alex Williamson wrote: > > >> > During a ho

Re: [Qemu-devel] [PATCH] virtio-net: Don't pass NULL peer to tap routines

2010-09-24 Thread Alex Williamson
On Fri, 2010-09-24 at 11:31 +0200, Markus Armbruster wrote: > Alex Williamson writes: > > > On Thu, 2010-09-23 at 12:43 -0500, Anthony Liguori wrote: > >> On 09/22/2010 02:52 PM, Alex Williamson wrote: > >> > During a hotplug, the netdev might be removed before the > > unplug? yep > >> > conne

Re: [Qemu-devel] [PATCH] virtio-net: Don't pass NULL peer to tap routines

2010-09-24 Thread Markus Armbruster
Alex Williamson writes: > On Thu, 2010-09-23 at 12:43 -0500, Anthony Liguori wrote: >> On 09/22/2010 02:52 PM, Alex Williamson wrote: >> > During a hotplug, the netdev might be removed before the unplug? >> > connected virtio device. When this happens, the guest might >> > be running cleanup o

Re: [Qemu-devel] [PATCH] virtio-net: Don't pass NULL peer to tap routines

2010-09-23 Thread Alex Williamson
On Thu, 2010-09-23 at 12:43 -0500, Anthony Liguori wrote: > On 09/22/2010 02:52 PM, Alex Williamson wrote: > > During a hotplug, the netdev might be removed before the > > connected virtio device. When this happens, the guest might > > be running cleanup operations that can trigger a segfault in >

Re: [Qemu-devel] [PATCH] virtio-net: Don't pass NULL peer to tap routines

2010-09-23 Thread Anthony Liguori
On 09/22/2010 02:52 PM, Alex Williamson wrote: During a hotplug, the netdev might be removed before the connected virtio device. When this happens, the guest might be running cleanup operations that can trigger a segfault in qemu. Avoid one set of these by checking whether the peer device is pr

[Qemu-devel] [PATCH] virtio-net: Don't pass NULL peer to tap routines

2010-09-22 Thread Alex Williamson
During a hotplug, the netdev might be removed before the connected virtio device. When this happens, the guest might be running cleanup operations that can trigger a segfault in qemu. Avoid one set of these by checking whether the peer device is present before trying to do tap operations. Signed