Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:20:41PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 18, 2013 at 04:14:08PM +0100, Stefan Hajnoczi wrote: > > On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: > > > object_get_canonical_path() returns a gchar*, it should be freeed by the > > > caller. > > > >

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 04:14:08PM +0100, Stefan Hajnoczi wrote: > On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: > > object_get_canonical_path() returns a gchar*, it should be freeed by the > > caller. > > > > Signed-off-by: Amos Kong > > --- > > hw/net/virtio-net.c | 8 > >

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: > object_get_canonical_path() returns a gchar*, it should be freeed by the > caller. > > Signed-off-by: Amos Kong > --- > hw/net/virtio-net.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to my net tree

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 08:47 AM, Amos Kong wrote: > object_get_canonical_path() returns a gchar*, it should be freeed by the > caller. > > Signed-off-by: Amos Kong Reviewed-by: Vlad Yasevich -vlad > --- > hw/net/virtio-net.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: > object_get_canonical_path() returns a gchar*, it should be freeed by the > caller. > > Signed-off-by: Amos Kong Reviewed-by: Michael S. Tsirkin > --- > hw/net/virtio-net.c | 8 > 1 file changed, 4 insertions(+), 4 deletions

[Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Amos Kong
object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong --- hw/net/virtio-net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 613f144..2b2fb57 100644 --- a/hw/net/virti