peer_{de,at}tach were called from inside assert(). This will be a
problem for virtio-net if built with NDEBUG.
Signed-off-by: Joel Stanley
---
hw/net/virtio-net.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 3626608..5
On Tue, Feb 11, 2014 at 10:42:02AM +1030, Joel Stanley wrote:
> peer_{de,at}tach were called from inside assert(). This will be a
> problem for virtio-net if built with NDEBUG.
>
> Signed-off-by: Joel Stanley
Thanks, applied.
> ---
> hw/net/virtio-net.c | 7 +--
> 1 file changed, 5 inserti
On Tue, Feb 11, 2014 at 07:03:17AM +0200, Michael S. Tsirkin wrote:
> On Tue, Feb 11, 2014 at 10:42:02AM +1030, Joel Stanley wrote:
> > peer_{de,at}tach were called from inside assert(). This will be a
> > problem for virtio-net if built with NDEBUG.
> >
> > Signed-off-by: Joel Stanley
>
> Thank
On Tue, Feb 11, 2014 at 3:40 PM, Michael S. Tsirkin wrote:
> Just to clarify, I applied this because code looks nicer this way.
> We don't support build with NDEBUG - a whole bunch of
> stuff will break if you do.
> I tweaked the commit log to make this clear.
Ok. Thanks for clarifying that.
Joe
