Re: [Qemu-devel] [PATCH] virtio-net: remove virtio queues if the guest doesn't support multiqueue

2015-07-15 Thread Wen Congyang
On 07/15/2015 03:41 PM, Jason Wang wrote: > > > On 07/15/2015 03:13 PM, Wen Congyang wrote: >> On 07/15/2015 02:59 PM, Jason Wang wrote: >>> >>> On 07/15/2015 02:23 PM, Wen Congyang wrote: commit da51a335 adds all queues in .realize(). But if the guest doesn't support multiqueue, we for

Re: [Qemu-devel] [PATCH] virtio-net: remove virtio queues if the guest doesn't support multiqueue

2015-07-15 Thread Jason Wang
On 07/15/2015 03:13 PM, Wen Congyang wrote: > On 07/15/2015 02:59 PM, Jason Wang wrote: >> >> On 07/15/2015 02:23 PM, Wen Congyang wrote: >>> commit da51a335 adds all queues in .realize(). But if the >>> guest doesn't support multiqueue, we forget to remove them. And >>> we cannot handle the ctrl

Re: [Qemu-devel] [PATCH] virtio-net: remove virtio queues if the guest doesn't support multiqueue

2015-07-15 Thread Wen Congyang
On 07/15/2015 02:59 PM, Jason Wang wrote: > > > On 07/15/2015 02:23 PM, Wen Congyang wrote: >> commit da51a335 adds all queues in .realize(). But if the >> guest doesn't support multiqueue, we forget to remove them. And >> we cannot handle the ctrl vq corretly. The guest will hang. >> >> Signed-o

Re: [Qemu-devel] [PATCH] virtio-net: remove virtio queues if the guest doesn't support multiqueue

2015-07-15 Thread Jason Wang
On 07/15/2015 02:23 PM, Wen Congyang wrote: > commit da51a335 adds all queues in .realize(). But if the > guest doesn't support multiqueue, we forget to remove them. And > we cannot handle the ctrl vq corretly. The guest will hang. > > Signed-off-by: Wen Congyang Thanks for the patch, some ques

[Qemu-devel] [PATCH] virtio-net: remove virtio queues if the guest doesn't support multiqueue

2015-07-14 Thread Wen Congyang
commit da51a335 adds all queues in .realize(). But if the guest doesn't support multiqueue, we forget to remove them. And we cannot handle the ctrl vq corretly. The guest will hang. Signed-off-by: Wen Congyang --- hw/net/virtio-net.c | 69 + 1