Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-16 Thread Greg Kurz
On Fri, 11 Sep 2015 16:01:56 +0800 Jason Wang wrote: > After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make > features 64bit wide"). Device's guest_features was actually set after > vdc->load(). This breaks the assumption that device specific load() Yeah...

Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-16 Thread Greg Kurz
On Fri, 11 Sep 2015 10:30:21 +0200 Cornelia Huck wrote: > On Fri, 11 Sep 2015 16:01:56 +0800 > Jason Wang wrote: > > > After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make > > features 64bit wide"). Device's guest_features was

Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-11 Thread Cornelia Huck
On Fri, 11 Sep 2015 16:01:56 +0800 Jason Wang wrote: > After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make > features 64bit wide"). Device's guest_features was actually set after > vdc->load(). This breaks the assumption that device specific load() >

[Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-11 Thread Jason Wang
After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make features 64bit wide"). Device's guest_features was actually set after vdc->load(). This breaks the assumption that device specific load() function can check guest_features. For virtio-net, self announcement and guest offloads