Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-07 Thread Ladi Prosek
On Mon, Nov 6, 2017 at 5:51 PM, Michael S. Tsirkin wrote: > On Mon, Nov 06, 2017 at 10:02:54AM +0100, Ladi Prosek wrote: >> On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin wrote: >> > On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: >> >> On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffma

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-06 Thread Michael S. Tsirkin
On Mon, Nov 06, 2017 at 10:18:07AM +0100, Gerd Hoffmann wrote: > Hi, > > > > So in my humble opinion the right thing for people to do is simply > > > to > > > avoid legacy devices. Is something preventing that? > > > > The same reasons why the concept of transitional devices exists at > > all?

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-06 Thread Michael S. Tsirkin
On Mon, Nov 06, 2017 at 10:02:54AM +0100, Ladi Prosek wrote: > On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin wrote: > > On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: > >> On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote: > >> > > >> >> > > Signed-off-by: Ladi Prosek > >> >

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-06 Thread Gerd Hoffmann
Hi, > > So in my humble opinion the right thing for people to do is simply > > to > > avoid legacy devices. Is something preventing that? > > The same reasons why the concept of transitional devices exists at > all? We discussing future driver versions running on future qemu versions, so we sh

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-06 Thread Ladi Prosek
On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin wrote: > On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: >> On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote: >> > >> >> > > Signed-off-by: Ladi Prosek >> >> > >> >> > I wonder whether it's a problem that legacy devices ignore >>

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-03 Thread Michael S. Tsirkin
On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: > On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote: > > > >> > > Signed-off-by: Ladi Prosek > >> > > >> > I wonder whether it's a problem that legacy devices ignore > >> > the subsystem ID (that's part of spec). > >> > >> I don't und

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-03 Thread Michael S. Tsirkin
On Fri, Nov 03, 2017 at 07:25:16AM +0100, Ladi Prosek wrote: > On Thu, Nov 2, 2017 at 3:52 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 02, 2017 at 02:31:15PM +0100, Ladi Prosek wrote: > >> The statement being removed doesn't change anything as virtio PCI devices > >> already > >> have Subsystem

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-03 Thread Vadim Rozenfeld
On 03/11/17 19:23, Ladi Prosek wrote: On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote: Signed-off-by: Ladi Prosek I wonder whether it's a problem that legacy devices ignore the subsystem ID (that's part of spec). I don't understand this comment. I don't see anything in the spec related

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-03 Thread Ladi Prosek
On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote: > >> > > Signed-off-by: Ladi Prosek >> > >> > I wonder whether it's a problem that legacy devices ignore >> > the subsystem ID (that's part of spec). >> >> I don't understand this comment. I don't see anything in the spec >> related to ignoring

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-03 Thread Gerd Hoffmann
> > > Signed-off-by: Ladi Prosek > > > > I wonder whether it's a problem that legacy devices ignore > > the subsystem ID (that's part of spec). > > I don't understand this comment. I don't see anything in the spec > related to ignoring the subsystem ID. Well, the subsystem *device* id is defin

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-02 Thread Ladi Prosek
On Thu, Nov 2, 2017 at 3:52 PM, Michael S. Tsirkin wrote: > On Thu, Nov 02, 2017 at 02:31:15PM +0100, Ladi Prosek wrote: >> The statement being removed doesn't change anything as virtio PCI devices >> already >> have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as >> Vendo

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-02 Thread Michael S. Tsirkin
On Thu, Nov 02, 2017 at 02:31:15PM +0100, Ladi Prosek wrote: > The statement being removed doesn't change anything as virtio PCI devices > already > have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as > Vendor > ID. And the Virtio spec does not require the two to be equal,

[Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-02 Thread Ladi Prosek
The statement being removed doesn't change anything as virtio PCI devices already have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as Vendor ID. And the Virtio spec does not require the two to be equal, either: "The PCI Subsystem Vendor ID and the PCI Subsystem Device I