Re: [Qemu-devel] [PATCH] virtio-scsi: finalize IOMMU support

2017-07-05 Thread Paolo Bonzini
On 05/07/2017 08:23, Fam Zheng wrote: >> req->vq = vq; >> req->dev = s; >> -qemu_sglist_init(>qsgl, DEVICE(s), 8, _space_memory); >> +qemu_sglist_init(>qsgl, DEVICE(s), 8, vdev->dma_as); > Not related to this patch, but is our vIOMMU iotlb implementation safe for > data >

Re: [Qemu-devel] [PATCH] virtio-scsi: finalize IOMMU support

2017-07-05 Thread Fam Zheng
On Tue, 07/04 20:21, Jason Wang wrote: > After converting to use DMA api for virtio devices, we should use > dma_as instead of address_space_memory. Otherwise it won't work if > IOMMU is enabled. > > Fixes: commit 8607f5c3072c ("virtio: convert to use DMA api") > Cc: qemu-sta...@nongnu.org >

Re: [Qemu-devel] [PATCH] virtio-scsi: finalize IOMMU support

2017-07-04 Thread Wei Xu
On Tue, Jul 04, 2017 at 08:21:06PM +0800, Jason Wang wrote: > After converting to use DMA api for virtio devices, we should use > dma_as instead of address_space_memory. Otherwise it won't work if > IOMMU is enabled. > > Fixes: commit 8607f5c3072c ("virtio: convert to use DMA api") > Cc:

Re: [Qemu-devel] [PATCH] virtio-scsi: finalize IOMMU support

2017-07-04 Thread Fam Zheng
On Tue, 07/04 20:21, Jason Wang wrote: > After converting to use DMA api for virtio devices, we should use > dma_as instead of address_space_memory. Otherwise it won't work if > IOMMU is enabled. > > Fixes: commit 8607f5c3072c ("virtio: convert to use DMA api") > Cc: qemu-sta...@nongnu.org >

[Qemu-devel] [PATCH] virtio-scsi: finalize IOMMU support

2017-07-04 Thread Jason Wang
After converting to use DMA api for virtio devices, we should use dma_as instead of address_space_memory. Otherwise it won't work if IOMMU is enabled. Fixes: commit 8607f5c3072c ("virtio: convert to use DMA api") Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang ---